Repository navigation
Create data channels as negotiated in single PC mode (protocol 18) - #1527
Open
cnderrauber wants to merge 4 commits into
Open
cnderrauber wants to merge 4 commits into
cnderrauber wants to merge 4 commits into
Conversation
Use fixed SCTP stream IDs (100/101/102) for the publisher data channels so the server can send on them without waiting for the client's DCEP OPEN, saving about one RTT of server->client readiness. Falls back to in-band channels when the server protocol is below 18 or it doesn't use single PC. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
lukasIO
reviewed
Oct 16, 2026
Comment on lines
+618
to
+619
| // The SCTP section is already in the offer, so in-band channels can be | ||
| // opened on it without renegotiation. |
Contributor
There was a problem hiding this comment.
this sounds like magic to me, can you explain how this works for older servers?
a couple of lines down we create the data channels with negotiated: false which makes it sound like we would still need negotiation.
Contributor
Author
There was a problem hiding this comment.
Sorry, my comment was a bit vague.. It means we don't need sdp renegotiation for the newly created data channels. Clarified 0e0a6c3
lukasIO
reviewed
Oct 16, 2026
Co-authored-by: lukasIO <mail@lukasseiler.de>
Co-authored-by: lukasIO <mail@lukasseiler.de>
lukasIO
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fixed SCTP stream IDs (100/101/102) for the publisher data channels so the server can send on them without waiting for the client's DCEP OPEN, saving about one RTT of server->client readiness. Falls back to in-band channels when the server protocol is below 18 or it doesn't use single PC.